-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Background service for databend #11751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
drmingdrmer
reviewed
Jun 14, 2023
drmingdrmer
reviewed
Jun 15, 2023
drmingdrmer
reviewed
Jun 16, 2023
drmingdrmer
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PS display implementation can be simplified
drmingdrmer
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Databend Internal Storage FuseTable is similar to Apache Iceberg, which is a Log Structured Table and need to compact/recluster/vacuum table regularly to merge small data chunks, sort them by the cluster key or vacuum unneeded branches.
Previously, those implementation rely on different drivers which add some complexity for infrastructure as we need to deploy and maintain additional service to trigger driver events.
Thus we need to introduce the Background Service, which allow to run databend as a background one-shot job or as a background daemon to run cron jobs,
jobs may trigger table maintainence tasks, for example, automatic compaction/vacuum/recluster by cron based/ critiria based without additional maintainence needed
This implementation contain:
one_shot
,interval
,cron
job type.Not contain:
Closes #issue